This repository has been archived by the owner on Sep 24, 2024. It is now read-only.
Update dataset generation and storage for ragas and prometheus #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfriedowitz
commented
Apr 4, 2024
sfriedowitz
commented
Apr 4, 2024
added 2 commits
April 4, 2024 16:07
sfriedowitz
commented
Apr 4, 2024
sfriedowitz
commented
Apr 4, 2024
imtihan
approved these changes
Apr 5, 2024
aittalam
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Thanks for working on this, Sean!
I think both the common storage path and the new dataset generation are nice features to have.
My only concern is what happens when the process breaks and if/how data can be recovered, but I saw Dataset.from_generator still saves incrementally by default and we can think about recovery after doing some tests with it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing
logurufor logging. We just need to be careful not to accidentally send the logger across Ray remote boundaries, as that would incur serialization issuesHow to test it
Related Jira Ticket
Additional notes for reviewers